Install uv-extension in v0.2.4 for PHP 7.x in test matrix#268
Merged
WyriHaximus merged 1 commit intoreactphp:1.xfrom Sep 4, 2023
Merged
Install uv-extension in v0.2.4 for PHP 7.x in test matrix#268WyriHaximus merged 1 commit intoreactphp:1.xfrom
WyriHaximus merged 1 commit intoreactphp:1.xfrom
Conversation
clue
approved these changes
Sep 1, 2023
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 👍
Agree this can be merged as is, but probably makes sense to look into using uv-0.3.0 on PHP 8+ in a follow-up (refs #264 and #250).
Member
Author
WyriHaximus
approved these changes
Sep 4, 2023
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
+1 on going with stable instead of beta for PHP 8
Member
Quick update: I've prepared a PR for this and will send an update once PHP 8.3 support has been merged (#269) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test matrix to install the pecl/uv extension in v0.2.4. Previously, we were always installing the latest version of this extension, which caused installation failures for pecl/uv on PHP 7 after the latest release of v0.3.0. This new version is only compatible with PHP 8 and above, I went back to the latest known version that works for PHP 7.
We became aware of this issue after @samsonasik test suite execution failed in #267.
For more reference about pecl/uv versions see: https://pecl.php.net/package/uv
Builds on top of #264.